Review and tidy solr/modules/sql code - #4840
Open
epugh wants to merge 1 commit into
Open
Conversation
Split out from apache#4743 into a per-module PR to make review easier. Contains the tidy-up changes to solr/modules/sql (StringBuilder conversions in SolrFilter's AND translation, .get(0) -> .getFirst(), dead-code removal, javadoc/comment fixes). Includes a restored fix: two @SuppressWarnings("resource") annotations on ParallelStream declarations in SolrTable.java that had been dropped by the tidy pass. ParallelStream is Closeable but ownership transfers to the caller's stream chain rather than being closed locally, so the annotation legitimately suppresses a false-positive leak warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Split out from #4743 into smaller, per-module PRs to make review easier. This PR contains the tidy-up changes to
solr/modules/sql(Calcite/JDBC integration).Solution
Leverage IntelliJ warnings (
StringBuilderconversions inSolrFilter's AND/OR translation,.get(0)→.getFirst(), dead-code removal, javadoc/comment fixes). TheSolrFilter/SolrAggregate/SolrEnumeratorpredicate-translation logic was checked to confirm AND/OR/NOT semantics are unchanged.Includes a restored fix: two
@SuppressWarnings("resource")annotations onParallelStreamdeclarations inSolrTable.javathat had been dropped by the original tidy pass.ParallelStreamisCloseable, but ownership transfers to the caller's stream chain rather than being closed locally in this method, so the annotation legitimately suppresses a false-positive resource-leak warning.Tests
existing
Relates to #4743